Review Request 127156: Call off EntryFilter::expireEntries has no effect

Thu Mar 10 17:57:03 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127156/
-----------------------------------------------------------

(Updated March 10, 2016, 5:57 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Changes
-------

Submitted with commit a694f8893d46cf775f3397f134761f01e66295d4 by Andreas Cord-Landwehr on behalf of Hartmut Riesenbeck to branch master.

Repository: parley

Description
-------

In EntryFilter::expireEntries() the set 
EntryFilter::m_entries is checked for entries 
which hasn't practiced for a defined amount of 
time and decreases the grad if this was expired.

But at time of calling expireEntries() this could 
not work because m_entries was not intialisised 
and empty. The method call was moved to a place 
where m_entries is filled and cleaned of invalid 
entries.

Diffs
-----

  src/collection/entryfilter.h 8eacf188d0d549c535efc55c22102d8a6aa88c62 
  src/collection/entryfilter.cpp a6a2efaf806e82406d07ca2294987f4a637bc719 

Diff: https://git.reviewboard.kde.org/r/127156/diff/

Testing
-------

Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160310/d1d4a2ce/attachment.html>