Review Request 127156: Call off EntryFilter::expireEntries has no effect

Hartmut Riesenbeck hartmut.riesenbeck at
Sun Mar 6 19:55:19 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated März 6, 2016, 7:55 nachm.)

Review request for KDE Edu.


Changed the practice date calculation for expired items as a result of 
the comment from Juliam Helfferich.

Repository: parley


In EntryFilter::expireEntries() the set 
EntryFilter::m_entries is checked for entries 
which hasn't practiced for a defined amount of 
time and decreases the grad if this was expired.

But at time of calling expireEntries() this could 
not work because m_entries was not intialisised 
and empty. The method call was moved to a place 
where m_entries is filled and cleaned of invalid 

Diffs (updated)

  src/collection/entryfilter.h 8eacf188d0d549c535efc55c22102d8a6aa88c62 
  src/collection/entryfilter.cpp a6a2efaf806e82406d07ca2294987f4a637bc719 




Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list