Review Request 127156: Call off EntryFilter::expireEntries has no effect

[Hartmut Riesenbeck]

> On März 4, 2016, 3:56 vorm., Julian Helfferich wrote:
> > src/collection/entryfilter.cpp, line 279
> > <https://git.reviewboard.kde.org/r/127156/diff/2/?file=447732#file447732line279>
> >
> >     The if-else construct can, in fact, be avoided by replacing Prefs::expireItem(grade - 2) with Prefs::blockItem(grade - 1).
> >     
> >     This serves two purposes:
> >     * Prevents entry from endless dropping
> >     * Item will not be blocked for the next practice round.
> >     
> >     To illustrate the last point: If blockTime(grade-1) > expireTime(grade-2), then the just expired item will become blocked.

Ok, good point. Haven't thought about this case. I have changed already the patch and will submit it right after.


- Hartmut


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127156/#review93148
-----------------------------------------------------------


On März 1, 2016, 8:43 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127156/
> -----------------------------------------------------------
> 
> (Updated März 1, 2016, 8:43 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> In EntryFilter::expireEntries() the set 
> EntryFilter::m_entries is checked for entries 
> which hasn't practiced for a defined amount of 
> time and decreases the grad if this was expired.
> 
> But at time of calling expireEntries() this could 
> not work because m_entries was not intialisised 
> and empty. The method call was moved to a place 
> where m_entries is filled and cleaned of invalid 
> entries.
> 
> 
> Diffs
> -----
> 
>   src/collection/entryfilter.h 8eacf188d0d549c535efc55c22102d8a6aa88c62 
>   src/collection/entryfilter.cpp 5264226f9f9cf69d6c77fefd498ffbbc744b56e7 
> 
> Diff: https://git.reviewboard.kde.org/r/127156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160306/65ba95aa/attachment.html>