Review Request 125150: Port KUrl -> QUrl
Andreas Cord-Landwehr
cordlandwehr at kde.org
Fri Sep 11 07:51:22 UTC 2015
> On Sept. 11, 2015, 1:52 vorm., Jeremy Whiting wrote:
> > src/tools/moleculeview.cpp, line 233
> > <https://git.reviewboard.kde.org/r/125150/diff/1/?file=402636#file402636line233>
> >
> > I'm not sure about this. What did KUrl url("kfiledialog:///kalzium"); do ?
That is used in KFileDialog to open the last location used with the keyword "kalzium" as starting directiory, i.e., application specific cache on last opened directory.
Still, I do not think it is worth the effort to re-implement this given that we will also port away from KFileDialog.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125150/#review85153
-----------------------------------------------------------
On Sept. 10, 2015, 11:55 nachm., Rahul Chowdhury wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125150/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 11:55 nachm.)
>
>
> Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.
>
>
> Repository: kalzium
>
>
> Description
> -------
>
> Port away from KUrl to QUrl
>
>
> Diffs
> -----
>
> plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp e802100
> plasmoid/engine/kalzium_engine.cpp 36fce6f
> src/detailinfodlg.h b1e9d48
> src/detailinfodlg.cpp 232adfa
> src/kalzium.cpp bfe8799
> src/kdeeduglossary.h d2cdbe9
> src/kdeeduglossary.cpp dddfa20
> src/tools/moleculeview.cpp 0bde181
> src/tools/obconverter.cpp 8e46249
>
> Diff: https://git.reviewboard.kde.org/r/125150/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rahul Chowdhury
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150911/ffcf87af/attachment.html>
More information about the kde-edu
mailing list