Review Request 125150: Port KUrl -> QUrl

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125150/#review85153
-----------------------------------------------------------



plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp (line 34)
<https://git.reviewboard.kde.org/r/125150/#comment58878>

    If this isn't used in the sources at all, just remove the #include.



plasmoid/engine/kalzium_engine.cpp (line 26)
<https://git.reviewboard.kde.org/r/125150/#comment58879>

    Same here.



src/tools/moleculeview.cpp (line 232)
<https://git.reviewboard.kde.org/r/125150/#comment58880>

    I'm not sure about this. What did KUrl url("kfiledialog:///kalzium"); do ?


- Jeremy Whiting


On Sept. 10, 2015, 5:55 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125150/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 5:55 p.m.)
> 
> 
> Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Port away from KUrl to QUrl
> 
> 
> Diffs
> -----
> 
>   plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp e802100 
>   plasmoid/engine/kalzium_engine.cpp 36fce6f 
>   src/detailinfodlg.h b1e9d48 
>   src/detailinfodlg.cpp 232adfa 
>   src/kalzium.cpp bfe8799 
>   src/kdeeduglossary.h d2cdbe9 
>   src/kdeeduglossary.cpp dddfa20 
>   src/tools/moleculeview.cpp 0bde181 
>   src/tools/obconverter.cpp 8e46249 
> 
> Diff: https://git.reviewboard.kde.org/r/125150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150911/99bd261a/attachment-0001.html>