<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125150/">https://git.reviewboard.kde.org/r/125150/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 11th, 2015, 1:52 vorm. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125150/diff/1/?file=402636#file402636line233" style="color: black; font-weight: bold; text-decoration: underline;">src/tools/moleculeview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MoleculeDialog::clearAllElementsInEditor()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">233</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">filename</span> <span class="o">=</span> <span class="n">KFileDialog</span><span class="o">::</span><span class="n">getSaveFileName</span><span class="p">(</span><span class="n"><span class="hl">url</span></span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">232</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">filename</span> <span class="o">=</span> <span class="n">KFileDialog</span><span class="o">::</span><span class="n">getSaveFileName</span><span class="p">(</span><span class="n"><span class="hl">QUrl</span></span><span class="p"><span class="hl">()</span>,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure about this. What did KUrl url("kfiledialog:///kalzium"); do ?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That is used in KFileDialog to open the last location used with the keyword "kalzium" as starting directiory, i.e., application specific cache on last opened directory.
Still, I do not think it is worth the effort to re-implement this given that we will also port away from KFileDialog.</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On September 10th, 2015, 11:55 nachm. UTC, Rahul Chowdhury wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.</div>
<div>By Rahul Chowdhury.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2015, 11:55 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port away from KUrl to QUrl</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp <span style="color: grey">(e802100)</span></li>
<li>plasmoid/engine/kalzium_engine.cpp <span style="color: grey">(36fce6f)</span></li>
<li>src/detailinfodlg.h <span style="color: grey">(b1e9d48)</span></li>
<li>src/detailinfodlg.cpp <span style="color: grey">(232adfa)</span></li>
<li>src/kalzium.cpp <span style="color: grey">(bfe8799)</span></li>
<li>src/kdeeduglossary.h <span style="color: grey">(d2cdbe9)</span></li>
<li>src/kdeeduglossary.cpp <span style="color: grey">(dddfa20)</span></li>
<li>src/tools/moleculeview.cpp <span style="color: grey">(0bde181)</span></li>
<li>src/tools/obconverter.cpp <span style="color: grey">(8e46249)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125150/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>