Review Request 123968: Simplify Finding GSL in CMake

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/#review81479
-----------------------------------------------------------


In addition to the items below, I suggest you try building Labplot with CMake 2.8.10 to check if it works fine with the `FindGSL.cmake` you've imported since that version was added to CMake after 2.8.10 and thus may use some features that are not present in that version.
Building CMake is easy, just make sure you use the binary you've built instead of your system one when calling it to build Labplot.


CMakeLists.txt (line 4)
<https://git.reviewboard.kde.org/r/123968/#comment55832>

    This will fail if you're using an older CMake, as you haven't added `cmake/` to `$CMAKE_MODULE_PATH` yet. And to prevent your version from always being used even if CMake ships its own `FindGSL.cmake` you could check `CMAKE_VERSION` and conditionally change `CMAKE_MODULE_PATH` before or after looking for `GSL`.



cmake/FindGSL.cmake (line 48)
<https://git.reviewboard.kde.org/r/123968/#comment55833>

    Note that the variable is now called `GSL_CBLAS_LIBRARY` and not `GSL_CBLAS_LIBRARIES`, so you need to adjust `src/CMakeLists.txt` (or use the imported target above).


- Raphael Kubo da Costa


On June 14, 2015, 9:42 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123968/
> -----------------------------------------------------------
> 
> (Updated June 14, 2015, 9:42 a.m.)
> 
> 
> Review request for KDE Edu and Marko Käning.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Use the module provided by CMake. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 980909c5b7b3effe70f0478f5e2128870f342e8f 
>   cmake/FindGSL.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123968/diff/
> 
> 
> Testing
> -------
> 
> Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150615/de3d0fa1/attachment.html>