Review Request 123968: Simplify Finding GSL in CMake

David Narváez david.narvaez at
Sun Jun 14 06:42:04 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated June 14, 2015, 6:42 a.m.)

Review request for KDE Edu and Marko Käning.


Including the GSL module.

Repository: labplot


Use the module provided by CMake. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.

Diffs (updated)

  CMakeLists.txt 980909c5b7b3effe70f0478f5e2128870f342e8f 
  cmake/FindGSL.cmake PRE-CREATION 



Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?


David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list