Review Request 123968: Simplify Finding GSL in CMake

David Narváez david.narvaez at computer.org
Tue Jun 30 10:40:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/
-----------------------------------------------------------

(Updated June 30, 2015, 10:40 a.m.)


Review request for KDE Edu and Marko Käning.


Changes
-------

Going back to my original idea of using PkgConfig since all this FindGSL idea is getting too complicated. I incorporated the original suggestions from Raphael about the include and library dirs.


Repository: labplot


Description
-------

Use the module provided by CMake. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.


Diffs (updated)
-----

  CMakeLists.txt 980909c5b7b3effe70f0478f5e2128870f342e8f 
  src/CMakeLists.txt a70299a6b29dbf6703d255f7b9b1c05b4a457da1 

Diff: https://git.reviewboard.kde.org/r/123968/diff/


Testing
-------

Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150630/7fd61ba7/attachment.html>


More information about the kde-edu mailing list