Review Request 122098: Remove redundant calls to lengend->updateContent()

[Shalin Shah]

On Jan. 19, 2015, 9:28 p.m., Shalin Shah wrote:
> > Makes sens. Thanks.

I applied patch in Applications/14.12 branch then checked out to master branch and merged it. However, I'm gettting a conflict while doing so in lengends file. It seems that you didn't merge one of my earlier bug fix - 342020 - with master. Anyways, so I removed conflict manually. So, in commit message I'd have to use SVN_MERGE? Can you help me with exact commit message?


- Shalin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122098/#review74358
-----------------------------------------------------------


On Jan. 20, 2015, 1:36 p.m., Shalin Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122098/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 1:36 p.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> There is no need to set up slot for updateContent(). Additionally, there is also no need to put updateContent() in slotUpdateSettings() since slotUpdateSettings() already makes a call to slotSwitchtoLookGradient() and slotSwitchtoLookScheme(), both of which update lengends.
> 
> 
> Diffs
> -----
> 
>   src/kalzium.cpp d23c2aa 
> 
> Diff: https://git.reviewboard.kde.org/r/122098/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shalin Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150120/56c325fe/attachment.html>