Review Request 122098: Remove redundant calls to lengend->updateContent()

[Etienne Rebetez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122098/#review74358
-----------------------------------------------------------

Ship it!



src/kalzium.cpp
<https://git.reviewboard.kde.org/r/122098/#comment51595>

    I would remove these comments. 
    The two functions are self-explanatory. Also, since you remove the updateContent, no one will understand this comment about the updateContent in this function:)


Makes sens. Thanks.

- Etienne Rebetez


On Jan. 17, 2015, 4:49 vorm., Shalin Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122098/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 4:49 vorm.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> There is no need to set up slot for updateContent(). Additionally, there is also no need to put updateContent() in slotUpdateSettings() since slotUpdateSettings() already makes a call to slotSwitchtoLookGradient() and slotSwitchtoLookScheme(), both of which update lengends.
> 
> 
> Diffs
> -----
> 
>   src/kalzium.cpp d23c2aa 
> 
> Diff: https://git.reviewboard.kde.org/r/122098/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shalin Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150119/32708d5a/attachment.html>