Review Request 122674: New option to ignore punctuations

[ankit wagadre]

> On Feb. 22, 2015, 2:05 p.m., Pino Toscano wrote:
> > - there was no need to open a *new* review request, please just update the old one (you already did it, so there is no reason to not to)
> > - the explanation you wrote in "Testing done" makes no sense, please try to write some meaningful English without contractions...

sorry new to review board.it won't happen again.


> On Feb. 22, 2015, 2:05 p.m., Pino Toscano wrote:
> > src/practice/writtenpracticevalidator.cpp, line 187
> > <https://git.reviewboard.kde.org/r/122674/diff/1/?file=350734#file350734line187>
> >
> >     What is this regular expression supposed to match here?

it'll remove all characters that dont belong to this range "a-zA-ZƒŠŒŽšœžŸÀ-ÿ" that is it will remove all punctuations and algebric symbols.


> On Feb. 22, 2015, 2:05 p.m., Pino Toscano wrote:
> > src/collection/testentry.h, line 29
> > <https://git.reviewboard.kde.org/r/122674/diff/1/?file=350730#file350730line29>
> >
> >     You don't need to add it with that exact value; just add the new flag at the end, without renumbering all the other ones.

i thought that it'll look and read good if punctuation and capitalization mistakes lie adjacent to each other,as they are alike.


- ankit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122674/#review76424
-----------------------------------------------------------


On Feb. 22, 2015, 7:55 p.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122674/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 7:55 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> option to ignore punctuations.check this one i'll delete old one.
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenbackendmode.cpp 7b221b7 
> 
> Diff: https://git.reviewboard.kde.org/r/122674/diff/
> 
> 
> Testing
> -------
> 
> i have done testing it works fine.and about ur comment that y should capitaliztion check for punctuation,if u ingnore capitalization is checked then the string should be checked for puntuation mistake for lower alphabets.
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150222/70157767/attachment-0001.html>