Review Request 122674: New option to ignore punctuations

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122674/#review76424
-----------------------------------------------------------


- there was no need to open a *new* review request, please just update the old one (you already did it, so there is no reason to not to)
- the explanation you wrote in "Testing done" makes no sense, please try to write some meaningful English without contractions...


src/collection/testentry.h
<https://git.reviewboard.kde.org/r/122674/#comment52640>

    You don't need to add it with that exact value; just add the new flag at the end, without renumbering all the other ones.



src/practice/configure/generalpracticeoptions.ui
<https://git.reviewboard.kde.org/r/122674/#comment52646>

    This contraddicts the default set in the .kcfg file. Please uncheck it, as it is handled by kconfigxt already.



src/practice/writtenbackendmode.cpp
<https://git.reviewboard.kde.org/r/122674/#comment52641>

    Style: missing space after }



src/practice/writtenbackendmode.cpp
<https://git.reviewboard.kde.org/r/122674/#comment52642>

    style



src/practice/writtenbackendmode.cpp
<https://git.reviewboard.kde.org/r/122674/#comment52643>

    style



src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122674/#comment52645>

    Why are you checking for punctuation mistakes also when checking for capitalization mistakes?



src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122674/#comment52644>

    What is this regular expression supposed to match here?


- Pino Toscano


On Feb. 22, 2015, 1:52 p.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122674/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 1:52 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> option to ignore punctuations.check this one i'll delete old one.
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenpracticevalidator.cpp e974441 
>   src/practice/configure/generalpracticeoptions.ui a40c739 
>   src/settings/parley.kcfg 0037420 
>   src/practice/writtenpracticevalidator.h 93e7423 
>   src/practice/writtenbackendmode.cpp 7b221b7 
>   src/collection/testentry.h 4f47c38 
> 
> Diff: https://git.reviewboard.kde.org/r/122674/diff/
> 
> 
> Testing
> -------
> 
> i have done testing it works fine.and about ur comment that y should capitaliztion check for punctuation,if u ingnore capitalization is checked then the string should be checked for puntuation mistake for lower alphabets.
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150222/b10dd4dd/attachment-0001.html>