Review Request 122674: New option to ignore punctuations

Inge Wallin inge at lysator.liu.se
Sun Feb 22 14:00:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122674/#review76426
-----------------------------------------------------------

Ship it!


This is ok now. Good work!

- Inge Wallin


On Feb. 22, 2015, 2:52 p.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122674/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 2:52 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> option to ignore punctuations.check this one i'll delete old one.
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenpracticevalidator.cpp e974441 
>   src/practice/configure/generalpracticeoptions.ui a40c739 
>   src/settings/parley.kcfg 0037420 
>   src/practice/writtenpracticevalidator.h 93e7423 
>   src/practice/writtenbackendmode.cpp 7b221b7 
>   src/collection/testentry.h 4f47c38 
> 
> Diff: https://git.reviewboard.kde.org/r/122674/diff/
> 
> 
> Testing
> -------
> 
> i have done testing it works fine.and about ur comment that y should capitaliztion check for punctuation,if u ingnore capitalization is checked then the string should be checked for puntuation mistake for lower alphabets.
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150222/b05f735e/attachment.html>


More information about the kde-edu mailing list