Review Request 118997: [analitza] Use CMake generate_export_header
Nicolás Alvarez
nicolas.alvarez at gmail.com
Sun Jun 29 19:24:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118997/
-----------------------------------------------------------
(Updated June 29, 2014, 4:24 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Repository: analitza
Description
-------
Use CMake generate_export_header.
The old *export.h headers only work on gcc because they use __attribute__((visibility)). Letting CMake generate the export headers creates macros that work on Windows/MSVC too, using dllexport/dllimport as appropriate.
Diffs
-----
CMakeLists.txt 6a3a387
analitza/CMakeLists.txt 3787d84
analitza/analitzaexport.h e80814c
analitzagui/CMakeLists.txt ab5e9d7
analitzagui/analitzaguiexport.h 764c543
analitzaplot/CMakeLists.txt 008febe
analitzaplot/analitzaplotexport.h fab3d2d
analitzawidgets/CMakeLists.txt 0aaaaee
analitzawidgets/analitzawidgets_export.h 27ad17b
Diff: https://git.reviewboard.kde.org/r/118997/diff/
Testing
-------
Builds on MSVC2013 (with other fixes I'll post later). GCC not tested.
Thanks,
Nicolás Alvarez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140629/a77f52ed/attachment.html>
More information about the kde-edu
mailing list