<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118997/">https://git.reviewboard.kde.org/r/118997/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Nicolás Alvarez.</div>
<p style="color: grey;"><i>Updated June 29, 2014, 4:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
analitza
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use CMake generate_export_header.
The old *export.h headers only work on gcc because they use __attribute__((visibility)). Letting CMake generate the export headers creates macros that work on Windows/MSVC too, using dllexport/dllimport as appropriate.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds on MSVC2013 (with other fixes I'll post later). GCC not tested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6a3a387)</span></li>
<li>analitza/CMakeLists.txt <span style="color: grey">(3787d84)</span></li>
<li>analitza/analitzaexport.h <span style="color: grey">(e80814c)</span></li>
<li>analitzagui/CMakeLists.txt <span style="color: grey">(ab5e9d7)</span></li>
<li>analitzagui/analitzaguiexport.h <span style="color: grey">(764c543)</span></li>
<li>analitzaplot/CMakeLists.txt <span style="color: grey">(008febe)</span></li>
<li>analitzaplot/analitzaplotexport.h <span style="color: grey">(fab3d2d)</span></li>
<li>analitzawidgets/CMakeLists.txt <span style="color: grey">(0aaaaee)</span></li>
<li>analitzawidgets/analitzawidgets_export.h <span style="color: grey">(27ad17b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118997/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>