Review Request 118997: [analitza] Use CMake generate_export_header

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118997/#review61201
-----------------------------------------------------------

Ship it!


Good! I was meaning to do that anyway :D.

- Aleix Pol Gonzalez


On June 28, 2014, 7:36 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118997/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 7:36 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> Use CMake generate_export_header.
>     
> The old *export.h headers only work on gcc because they use __attribute__((visibility)). Letting CMake generate the export headers creates macros that work on Windows/MSVC too, using dllexport/dllimport as appropriate.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6a3a387 
>   analitza/CMakeLists.txt 3787d84 
>   analitza/analitzaexport.h e80814c 
>   analitzagui/CMakeLists.txt ab5e9d7 
>   analitzagui/analitzaguiexport.h 764c543 
>   analitzaplot/CMakeLists.txt 008febe 
>   analitzaplot/analitzaplotexport.h fab3d2d 
>   analitzawidgets/CMakeLists.txt 0aaaaee 
>   analitzawidgets/analitzawidgets_export.h 27ad17b 
> 
> Diff: https://git.reviewboard.kde.org/r/118997/diff/
> 
> 
> Testing
> -------
> 
> Builds on MSVC2013 (with other fixes I'll post later). GCC not tested.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140629/04769a0c/attachment.html>