Review Request 118957: Fix search path in FindReadline.cmake

[Vadim Zhukov]

> On June 26, 2014, 6:07 p.m., Aleix Pol Gonzalez wrote:
> > cmake/FindReadline.cmake, line 6
> > <https://git.reviewboard.kde.org/r/118957/diff/2/?file=284819#file284819line6>
> >
> >     Change it to HINTS?

Why? It's not needed at all, unless on some crazy system there exists /usr/include/readline/readline/readline.h. I'm not aware of any, and Google agrees with me.

"FIND_PATH(READLINE_INCLUDE_DIR readline/readline.h)" means "try every default search directory by appending 'readline/readline.h' to it and checking if the file at the given path exists". So CMake will try "/usr/include/readline/readline.h" anyway, because "/usr/include" is in default search path on all *nix platforms, unless I'm mistaken. I don't see "/usr/include" in Find*.cmake from CMake distribution, either (with a few highly specific exceptions).


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118957/#review61028
-----------------------------------------------------------


On June 26, 2014, 4:50 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118957/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 4:50 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> The "/usr/include/readline" path specification in FIND_PATH() call is extraneous:
> 
> 1. "readline/" prefix is already present in the FIND_PATH() argument "readline/readline.h", so it should be cut off the path;
> 2. "/usr/include" is in standard search path for CMake.
> 
> This is probably a leftover from times when analitza tried to use "readline.h" instead of "readline/readline.h".
> 
> 
> Diffs
> -----
> 
>   cmake/FindReadline.cmake 8fc21ec 
> 
> Diff: https://git.reviewboard.kde.org/r/118957/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140626/fa93d985/attachment-0001.html>