Review Request 118957: Fix search path in FindReadline.cmake
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Jun 26 21:57:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118957/#review61050
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 26, 2014, 12:50 p.m., Vadim Zhukov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118957/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 12:50 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: analitza
>
>
> Description
> -------
>
> The "/usr/include/readline" path specification in FIND_PATH() call is extraneous:
>
> 1. "readline/" prefix is already present in the FIND_PATH() argument "readline/readline.h", so it should be cut off the path;
> 2. "/usr/include" is in standard search path for CMake.
>
> This is probably a leftover from times when analitza tried to use "readline.h" instead of "readline/readline.h".
>
>
> Diffs
> -----
>
> cmake/FindReadline.cmake 8fc21ec
>
> Diff: https://git.reviewboard.kde.org/r/118957/diff/
>
>
> Testing
> -------
>
> OpenBSD/i386-CURRENT
>
>
> Thanks,
>
> Vadim Zhukov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140626/b92fe075/attachment.html>
More information about the kde-edu
mailing list