Review Request 118957: Fix search path in FindReadline.cmake

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118957/#review61028
-----------------------------------------------------------



cmake/FindReadline.cmake
<https://git.reviewboard.kde.org/r/118957/#comment42501>

    Change it to HINTS?


- Aleix Pol Gonzalez


On June 26, 2014, 12:50 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118957/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 12:50 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> The "/usr/include/readline" path specification in FIND_PATH() call is extraneous:
> 
> 1. "readline/" prefix is already present in the FIND_PATH() argument "readline/readline.h", so it should be cut off the path;
> 2. "/usr/include" is in standard search path for CMake.
> 
> This is probably a leftover from times when analitza tried to use "readline.h" instead of "readline/readline.h".
> 
> 
> Diffs
> -----
> 
>   cmake/FindReadline.cmake 8fc21ec 
> 
> Diff: https://git.reviewboard.kde.org/r/118957/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140626/cf742295/attachment.html>