Review Request 118957: Fix search path in FindReadline.cmake

Vadim Zhukov persgray at gmail.com
Thu Jun 26 12:50:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118957/
-----------------------------------------------------------

Review request for KDE Edu.


Repository: analitza


Description
-------

The "/usr/include/readline" path specification in FIND_PATH() call is extraneous:

1. "readline/" prefix is already present in the FIND_PATH() argument "readline/readline.h", so it should be cut off the path;
2. "/usr/include" is in standard search path for CMake.

This is probably a leftover from times when analitza tried to use "readline.h" instead of "readline/readline.h".


Diffs
-----

  cmake/FindReadline.cmake 8fc21ec 

Diff: https://git.reviewboard.kde.org/r/118957/diff/


Testing
-------

OpenBSD/i386-CURRENT


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140626/bf66133e/attachment.html>


More information about the kde-edu mailing list