Review Request 118926: Port from KLocale::dirs to QStandardPaths.

Jeremy Whiting jpwhiting at kde.org
Wed Jun 25 02:59:38 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118926/
-----------------------------------------------------------

(Updated June 24, 2014, 8:59 p.m.)


Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.


Changes
-------

Updated with fixes needed.

I also locally created a small test application to test SharedKvtmlFiles but when I try to build it I get link errors as follows:

Linking CXX executable sharedkvtmlfilestest
../libKEduVocDocument.so.5.0.0: undefined reference to `KEduVocDocument::docModified(bool)'
../libKEduVocDocument.so.5.0.0: undefined reference to `vtable for KEduVocDocument'
../libKEduVocDocument.so.5.0.0: undefined reference to `vtable for KEduVocKvtmlReader'
../libKEduVocDocument.so.5.0.0: undefined reference to `vtable for KEduVocKvtml2Reader'

if I change it to link against kde4's libkeduvocdocument it links fine (but segfaults in sonnet). Any idea what I'm missing here?


Repository: libkdeedu


Description
-------

Port from KLocale::dirs to QStandardPaths.


Diffs (updated)
-----

  keduvocdocument/sharedkvtmlfiles.cpp 1a9e833ebbfc8065cde6e9d46808a98a26c3f9da 

Diff: https://git.reviewboard.kde.org/r/118926/diff/


Testing
-------


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140625/33db5602/attachment.html>


More information about the kde-edu mailing list