Review Request 118926: Port from KLocale::dirs to QStandardPaths.

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jun 26 00:05:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118926/#review60988
-----------------------------------------------------------

Ship it!


Maybe it's a problem with moc? I've seen that before.

I couldn't find any problem with the patch, so it can probably go in. Maybe you can add the test in a tests directory and we can figure out there what's going on.

- Aleix Pol Gonzalez


On June 25, 2014, 2:59 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118926/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 2:59 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> 
> 
> Repository: libkdeedu
> 
> 
> Description
> -------
> 
> Port from KLocale::dirs to QStandardPaths.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/sharedkvtmlfiles.cpp 1a9e833ebbfc8065cde6e9d46808a98a26c3f9da 
> 
> Diff: https://git.reviewboard.kde.org/r/118926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140626/f375cd68/attachment.html>


More information about the kde-edu mailing list