Review Request 118926: Port from KLocale::dirs to QStandardPaths.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118926/#review60922
-----------------------------------------------------------



keduvocdocument/sharedkvtmlfiles.cpp
<https://git.reviewboard.kde.org/r/118926/#comment42428>

    NoDotAndDotDot is unneeded if already filtering for files only.



keduvocdocument/sharedkvtmlfiles.cpp
<https://git.reviewboard.kde.org/r/118926/#comment42426>

    .clear + .append is the same as:
    nameFilter = "*.txt".



keduvocdocument/sharedkvtmlfiles.cpp
<https://git.reviewboard.kde.org/r/118926/#comment42427>

    if you list files, nodotanddotdot is unneeded AFAIK.



keduvocdocument/sharedkvtmlfiles.cpp
<https://git.reviewboard.kde.org/r/118926/#comment42425>

    Why '/'+"khangman" instead of "/khangman".


I know I'm very insisting, but testing this would be really good, I've messed up big time when porting away from KStandardDirs.

- Aleix Pol Gonzalez


On June 25, 2014, 1:35 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118926/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 1:35 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> 
> 
> Repository: libkdeedu
> 
> 
> Description
> -------
> 
> Port from KLocale::dirs to QStandardPaths.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/sharedkvtmlfiles.cpp 1a9e833ebbfc8065cde6e9d46808a98a26c3f9da 
> 
> Diff: https://git.reviewboard.kde.org/r/118926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140625/a4665c8a/attachment-0001.html>