Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117917/#review60702
-----------------------------------------------------------

Ship it!


looks good. thanks for working on this. obviously this is only a first step but it's already a big imporvement over just crashing. So I think you should backport this fix to 4.13 so at least we don't crash there and then we can focus on properly bringing back the feature in an upcoming feature relase.

- Alexander Rieder


On June 5, 2014, 1:17 p.m., Lucas Hermann Negri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117917/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 1:17 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The latex export procedure always tried to access a null pointer, so it always resulted in a crash. Also, the user was asked about exporting the images too, but the read value was never used.
> 
> I've fixed the crash, but there is still missing functionality. I've added basic support for exporting the images, since it was ignoring the user option to export images, but it is far from complete since the images are not referenced inside the latex file.
> 
> 
> Diffs
> -----
> 
>   src/cantor_part.cpp eda5fd6 
>   src/latexentry.cpp b3ce962 
>   src/worksheet.h 468bd5f 
>   src/worksheet.cpp 082e116 
> 
> Diff: https://git.reviewboard.kde.org/r/117917/diff/
> 
> 
> Testing
> -------
> 
> Latex export seems to be working with or without exporting images too.
> 
> 
> Thanks,
> 
> Lucas Hermann Negri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140622/80b12b5c/attachment.html>