Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX

[Lucas Hermann Negri]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117917/
-----------------------------------------------------------

(Updated June 5, 2014, 1:17 p.m.)


Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.


Changes
-------

Hi. I've studied this issue and it seems for me that there is two separated issues: the latexentry toXml() has a bug (that this patch should fix) and the image results should be included to the exported latex file (not covered by this patch). Rendering of latex equations should not be exported as images, so the current behavior of the latexentry and textentry with latex content ($$ ... $$) is correct.

As no *entry implementation actually uses the exportImages option, I've just fixed the latexEntry() toXml and removed the dialog that asked if the user wanted to export images, as the result is just ignored.

I think this patch is a first work towards the correct design, since it fixes a certain crash with latexentry.cpp. The 'exporting images feature' seems to be part of other files, and maybe another future patch.


Repository: cantor


Description
-------

The latex export procedure always tried to access a null pointer, so it always resulted in a crash. Also, the user was asked about exporting the images too, but the read value was never used.

I've fixed the crash, but there is still missing functionality. I've added basic support for exporting the images, since it was ignoring the user option to export images, but it is far from complete since the images are not referenced inside the latex file.


Diffs (updated)
-----

  src/cantor_part.cpp eda5fd6 
  src/latexentry.cpp b3ce962 
  src/worksheet.h 468bd5f 
  src/worksheet.cpp 082e116 

Diff: https://git.reviewboard.kde.org/r/117917/diff/


Testing
-------

Latex export seems to be working with or without exporting images too.


Thanks,

Lucas Hermann Negri

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140605/fcb9345f/attachment.html>