Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX

Lucas Hermann Negri lucashnegri at gmail.com
Sun Jun 22 20:06:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117917/
-----------------------------------------------------------

(Updated June 22, 2014, 8:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.


Repository: cantor


Description
-------

The latex export procedure always tried to access a null pointer, so it always resulted in a crash. Also, the user was asked about exporting the images too, but the read value was never used.

I've fixed the crash, but there is still missing functionality. I've added basic support for exporting the images, since it was ignoring the user option to export images, but it is far from complete since the images are not referenced inside the latex file.


Diffs
-----

  src/cantor_part.cpp eda5fd6 
  src/latexentry.cpp b3ce962 
  src/worksheet.h 468bd5f 
  src/worksheet.cpp 082e116 

Diff: https://git.reviewboard.kde.org/r/117917/diff/


Testing
-------

Latex export seems to be working with or without exporting images too.


Thanks,

Lucas Hermann Negri

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140622/859e591b/attachment.html>


More information about the kde-edu mailing list