Review Request 118810: Parley: Fixing limiting of number of words per session/day.

[Andreas Xavier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118810/
-----------------------------------------------------------

(Updated June 18, 2014, 9:39 a.m.)


Review request for KDE Edu.


Changes
-------

Restores per session behavior
Replaces std::min with qMin
Restores memory leak for future patch


Repository: parley


Description
-------

I will be submitting v2 in about 30 seconds, for simultaneous discussion.


Problem: The problem was more of a bug fix than a new feature.  Because the new words were added at the top of the function, every session added n new words.  Each new word requires 7 practice sessions on the first day.  Consequently, the user is overwhelmed by new words.

For example a user uses a session size of 30 words with 4 new words per session and practices 10 times per day.

number of practices per day = 30*10 = 300
number used up by new words = 4 * 7 *10 = 280

If the user adds 1 more word they  will be buried under a deluge of new words.


Solution: Choose the new words after choosing from the older words.  This means that after you have practiced all of the words scheduled for the day each session will only contain numNewWords words. (i.e. 4 from the previous example)


Bonus:  Fixed the memory leak, by removing the to be practiced words from the list of all possible candidates and then deleting the unused candidates.

  


Diffs (updated)
-----

  src/practice/sessionmanagerfixed.cpp 5000f62 

Diff: https://git.reviewboard.kde.org/r/118810/diff/


Testing
-------

Did multiple choice until I exhausted my daily words.  I counted the number of new words presented.


Thanks,

Andreas Xavier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140618/c3ed002f/attachment.html>