Review Request 118810: Parley: Fixing limiting of number of words per session/day.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118810/#review60365
-----------------------------------------------------------


Hi Andreas and thanks for this patch.

However, it seems that you have misunderstood what I was talking about in IRC. I don't want to introduce any limit on new words per day.  Some university students learn several hundred words per week and also other people may be studying quite hard. What I want to do is to introduce a configurable limit on the number of words that have grade 0 at any given time.  This has nothing to do with days; as soon as one word goes from grade 0 to grade 1 a new untrained word can be introduced in the next session.

>From your description it also seems that you think there is a limit to the number of sessions per day that a student can train. The session concept is just there to break up a huge number of words into manageable pieces. There is nothing to prevent a student from running 10 sessions in a row immediately after each other. I sometimes do that myself.

So you need to change your approach a bit, but in general you have grasped the meaning of the code well.


src/configure-practice/generalpracticeoptions.ui
<https://git.reviewboard.kde.org/r/118810/#comment42097>

    Hmm, we don't have anything per day at all in Parley.  Do you mean new words per session? The user can run any number of sessions per day.



src/configure-practice/generalpracticeoptions.ui
<https://git.reviewboard.kde.org/r/118810/#comment42098>

    Definitely not.  The max number of new words per session must stay.



src/practice/sessionmanagerfixed.cpp
<https://git.reviewboard.kde.org/r/118810/#comment42099>

    Should use QMin instead.



src/practice/sessionmanagerfixed.cpp
<https://git.reviewboard.kde.org/r/118810/#comment42100>

    I am  not sure that this is correct. In fact, I'm sure that it is not.
    
    The test entries are owned by m_allTestEntries and they should not be deleted anywhere else. All other test entry lists are only references into this list but not owners.


- Inge Wallin


On June 18, 2014, 7:01 a.m., Andreas Xavier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118810/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 7:01 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> I will be submitting v2 in about 30 seconds, for simultaneous discussion.
> 
> 
> Problem: The problem was more of a bug fix than a new feature.  Because the new words were added at the top of the function, every session added n new words.  Each new word requires 7 practice sessions on the first day.  Consequently, the user is overwhelmed by new words.
> 
> For example a user uses a session size of 30 words with 4 new words per session and practices 10 times per day.
> 
> number of practices per day = 30*10 = 300
> number used up by new words = 4 * 7 *10 = 280
> 
> If the user adds 1 more word they  will be buried under a deluge of new words.
> 
> 
> Solution: Choose the new words after choosing from the older words.  This means that after you have practiced all of the words scheduled for the day each session will only contain numNewWords words. (i.e. 4 from the previous example)
> 
> 
> Bonus:  Fixed the memory leak, by removing the to be practiced words from the list of all possible candidates and then deleting the unused candidates.
> 
>   
> 
> 
> Diffs
> -----
> 
>   src/configure-practice/generalpracticeoptions.ui 90a407f 
>   src/practice/sessionmanagerfixed.cpp 5000f62 
>   src/settings/parley.kcfg e0f48af 
> 
> Diff: https://git.reviewboard.kde.org/r/118810/diff/
> 
> 
> Testing
> -------
> 
> Did multiple choice until I exhausted my daily words.  I counted the number of new words presented.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140618/1d17236b/attachment-0001.html>