<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118810/">https://git.reviewboard.kde.org/r/118810/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Andreas Xavier.</div>
<p style="color: grey;"><i>Updated June 18, 2014, 9:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restores per session behavior
Replaces std::min with qMin
Restores memory leak for future patch</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will be submitting v2 in about 30 seconds, for simultaneous discussion.
Problem: The problem was more of a bug fix than a new feature. Because the new words were added at the top of the function, every session added n new words. Each new word requires 7 practice sessions on the first day. Consequently, the user is overwhelmed by new words.
For example a user uses a session size of 30 words with 4 new words per session and practices 10 times per day.
number of practices per day = 30*10 = 300
number used up by new words = 4 * 7 *10 = 280
If the user adds 1 more word they will be buried under a deluge of new words.
Solution: Choose the new words after choosing from the older words. This means that after you have practiced all of the words scheduled for the day each session will only contain numNewWords words. (i.e. 4 from the previous example)
Bonus: Fixed the memory leak, by removing the to be practiced words from the list of all possible candidates and then deleting the unused candidates.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did multiple choice until I exhausted my daily words. I counted the number of new words presented.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/sessionmanagerfixed.cpp <span style="color: grey">(5000f62)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118810/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>