Review Request 115439: Open ExpressionWritter API: AbstractExpressionWriter

Percy Camilo Triveño Aucahuasi percy.camilo.ta at
Mon Feb 3 07:13:13 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Edu.

Repository: analitza


Currently ExpressionWriter allows a great flexibility to visit each node (by type) of the parser's tree, but it returns only QString as result.

I propose open this API by this generic interface: AbstractExpressionWriter. This interface can be used by any client to visit the tree and, in addition, the client can choose the type of the results for each visit.

This patch adds AbstractExpressionWriter, ExpressionWriter, List, CustomObject, Matrix, Apply and Container as public API (headers will be installed)


  analitza/expressionwriter.h ea9c92d 
  analitza/abstractexpressionwriter.h PRE-CREATION 
  analitza/CMakeLists.txt af270b6 



build & install ok, also each class has the ANALITZA_EXPORT macro.


Percy Camilo Triveño Aucahuasi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list