Review Request 115439: Open ExpressionWritter API: AbstractExpressionWriter

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115439/#review48816
-----------------------------------------------------------


You're not modifying the visit methods, you probably want them to use the abstract visitor.

- Aleix Pol Gonzalez


On Feb. 3, 2014, 7:13 a.m., Percy Camilo Triveño Aucahuasi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115439/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 7:13 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> Currently ExpressionWriter allows a great flexibility to visit each node (by type) of the parser's tree, but it returns only QString as result.
> 
> I propose open this API by this generic interface: AbstractExpressionWriter. This interface can be used by any client to visit the tree and, in addition, the client can choose the type of the results for each visit.
> 
> This patch adds AbstractExpressionWriter, ExpressionWriter, List, CustomObject, Matrix, Apply and Container as public API (headers will be installed)
> 
> 
> Diffs
> -----
> 
>   analitza/expressionwriter.h ea9c92d 
>   analitza/abstractexpressionwriter.h PRE-CREATION 
>   analitza/CMakeLists.txt af270b6 
> 
> Diff: https://git.reviewboard.kde.org/r/115439/diff/
> 
> 
> Testing
> -------
> 
> build & install ok, also each class has the ANALITZA_EXPORT macro.
> 
> 
> Thanks,
> 
> Percy Camilo Triveño Aucahuasi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140203/9f150e54/attachment.html>