Review Request 117637: Add importPackage menu to Octave backend in Cantor

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117637/#review57031
-----------------------------------------------------------

Ship it!


Looks good and works as expected.
The only thing I've noticed (for all backends), is that the inital focus of the Dialog is on the Ok button, instead of the text-field which is a little annoying. Could you fix that please?

- Alexander Rieder


On April 18, 2014, 9:01 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117637/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 9:01 p.m.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> This diff add OctavePackagingExtension::importPackage to Octave backend, like in Python 2 backend. It enable a menu item in menu bar to import packages in Octave environment.
> 
> 
> Diffs
> -----
> 
>   src/backends/octave/octavebackend.cpp 4ad3f71 
>   src/backends/octave/octaveextensions.h 9729313 
>   src/backends/octave/octaveextensions.cpp ab09f06 
> 
> Diff: https://git.reviewboard.kde.org/r/117637/diff/
> 
> 
> Testing
> -------
> 
> The diff compile without errors. You can test it importing any Octave package using the menu. You can see a list of Octave packages in http://octave.sourceforge.net/packages.php. Informations about installation/unistallation/listing Octave packages can be found in http://www.gnu.org/software/octave/doc/interpreter/Installing-and-Removing-Packages.html
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20140430/ebad4a9a/attachment.html>