<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117637/">https://git.reviewboard.kde.org/r/117637/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good and works as expected.
The only thing I've noticed (for all backends), is that the inital focus of the Dialog is on the Ok button, instead of the text-field which is a little annoying. Could you fix that please?</pre>
<br />
<p>- Alexander Rieder</p>
<br />
<p>On April 18th, 2014, 9:01 p.m. UTC, Filipe Saraiva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated April 18, 2014, 9:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This diff add OctavePackagingExtension::importPackage to Octave backend, like in Python 2 backend. It enable a menu item in menu bar to import packages in Octave environment.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The diff compile without errors. You can test it importing any Octave package using the menu. You can see a list of Octave packages in http://octave.sourceforge.net/packages.php. Informations about installation/unistallation/listing Octave packages can be found in http://www.gnu.org/software/octave/doc/interpreter/Installing-and-Removing-Packages.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/octave/octavebackend.cpp <span style="color: grey">(4ad3f71)</span></li>
<li>src/backends/octave/octaveextensions.h <span style="color: grey">(9729313)</span></li>
<li>src/backends/octave/octaveextensions.cpp <span style="color: grey">(ab09f06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>