Review Request: Fixing Krazy code checker issues

[Akarsh Simha]

> On Jan. 5, 2013, 9:20 a.m., Torsten Rahn wrote:
> > kstars/printing/pwizfovsh.cpp, line 66
> > <http://git.reviewboard.kde.org/r/108184/diff/1/?file=104822#file104822line66>
> >
> >     that looks a bit awkward to me in terms of coding style. I guess that should rather be 
> >     
> >             QPointer<DetailDialog> detailDlg = new DetailDialog(m_ParentWizard->getShBeginObject(), KStars::Instance()->data()->ut(),
> >     KStars::Instance()->data()->geo(), this));
> >     
> >     But I'm not a KStars guy, so ...
> >

Agree with Torsten. Please use the coding style recommended by Torsten.


- Akarsh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108184/#review24729
-----------------------------------------------------------


On Jan. 4, 2013, 11:13 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108184/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 11:13 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8193206
> 
> 
> Diffs
> -----
> 
>   kstars/ekos/guide/gmath.cpp bf629a2 
>   kstars/ekos/guide/guider.cpp 30c6bcd 
>   kstars/ekos/guide/rcalibration.cpp 3340ae4 
>   kstars/ekos/guide/scroll_graph.cpp a37e81c 
>   kstars/fitsviewer/fitsviewer.cpp d5c3fcb 
>   kstars/printing/pwizfovsh.cpp b5a4101 
>   kstars/printing/pwizobjectselection.cpp 50b9f5a 
>   kstars/skyobjects/satellite.cpp 0ca44f7 
>   kstars/tools/conjunctions.cpp 6b8c081 
>   kstars/tools/modcalcvlsr.cpp 2a9b355 
> 
> Diff: http://git.reviewboard.kde.org/r/108184/diff/
> 
> 
> Testing
> -------
> 
> Yes, compiled and tested
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130105/86dea53e/attachment-0001.html>