Review Request: Fixing Krazy code checker issues

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108184/#review24729
-----------------------------------------------------------


can't give a "Ship it", since I don't know what they prefer. The dialog.exec issues should get resolved though.


kstars/printing/pwizfovsh.cpp
<http://git.reviewboard.kde.org/r/108184/#comment18988>

    see below



kstars/printing/pwizfovsh.cpp
<http://git.reviewboard.kde.org/r/108184/#comment18987>

    that looks a bit awkward to me in terms of coding style. I guess that should rather be 
    
            QPointer<DetailDialog> detailDlg = new DetailDialog(m_ParentWizard->getShBeginObject(), KStars::Instance()->data()->ut(),
    KStars::Instance()->data()->geo(), this));
    
    But I'm not a KStars guy, so ...
    



kstars/printing/pwizobjectselection.cpp
<http://git.reviewboard.kde.org/r/108184/#comment18989>

    see above



kstars/printing/pwizobjectselection.cpp
<http://git.reviewboard.kde.org/r/108184/#comment18990>

    See above.



kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/108184/#comment18991>

    See above



kstars/tools/modcalcvlsr.cpp
<http://git.reviewboard.kde.org/r/108184/#comment18992>

    See above


- Torsten Rahn


On Jan. 4, 2013, 11:13 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108184/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 11:13 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8193206
> 
> 
> Diffs
> -----
> 
>   kstars/ekos/guide/gmath.cpp bf629a2 
>   kstars/ekos/guide/guider.cpp 30c6bcd 
>   kstars/ekos/guide/rcalibration.cpp 3340ae4 
>   kstars/ekos/guide/scroll_graph.cpp a37e81c 
>   kstars/fitsviewer/fitsviewer.cpp d5c3fcb 
>   kstars/printing/pwizfovsh.cpp b5a4101 
>   kstars/printing/pwizobjectselection.cpp 50b9f5a 
>   kstars/skyobjects/satellite.cpp 0ca44f7 
>   kstars/tools/conjunctions.cpp 6b8c081 
>   kstars/tools/modcalcvlsr.cpp 2a9b355 
> 
> Diff: http://git.reviewboard.kde.org/r/108184/diff/
> 
> 
> Testing
> -------
> 
> Yes, compiled and tested
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130105/4d1ed0c3/attachment-0001.html>