Review Request: Fixing Krazy code checker issues

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108184/#review24739
-----------------------------------------------------------



kstars/fitsviewer/fitsviewer.cpp
<http://git.reviewboard.kde.org/r/108184/#comment19006>

    well, I guess from the that should have been const QString &filter



kstars/printing/pwizfovsh.cpp
<http://git.reviewboard.kde.org/r/108184/#comment19007>

    ah, no.
    The whole purpose of using QPointer is to be able to check for the dialog instance's validity.
    this should be something like
    SkyObject *obj = findDlg ? findDlg->selectedObject() : 0;



kstars/printing/pwizfovsh.cpp
<http://git.reviewboard.kde.org/r/108184/#comment19008>

    this seems to be an intentation problem, d of delete should be aligned with d of detailDlg in the line before



kstars/printing/pwizobjectselection.cpp
<http://git.reviewboard.kde.org/r/108184/#comment19009>

    missing check for pointer validity, see above



kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/108184/#comment19010>

    missing pointer validity check.
    however, since geoPlace is not checked, I recommend adding it to the line before
    if ( ld->exec() == QDialog::Accepted && ld ) {



kstars/tools/conjunctions.cpp
<http://git.reviewboard.kde.org/r/108184/#comment19011>

    placement of ampersand
    const QString &object



kstars/tools/modcalcvlsr.cpp
<http://git.reviewboard.kde.org/r/108184/#comment19012>

    see above


- Kevin Krammer


On Jan. 5, 2013, 9:43 a.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108184/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 9:43 a.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8193206
> 
> 
> Diffs
> -----
> 
>   kstars/ekos/guide/gmath.cpp bf629a2 
>   kstars/ekos/guide/guider.cpp 30c6bcd 
>   kstars/ekos/guide/rcalibration.cpp 3340ae4 
>   kstars/ekos/guide/scroll_graph.cpp a37e81c 
>   kstars/fitsviewer/fitsviewer.cpp d5c3fcb 
>   kstars/printing/pwizfovsh.cpp b5a4101 
>   kstars/printing/pwizobjectselection.cpp 50b9f5a 
>   kstars/skyobjects/satellite.cpp 0ca44f7 
>   kstars/tools/conjunctions.cpp 6b8c081 
>   kstars/tools/modcalcvlsr.cpp 2a9b355 
> 
> Diff: http://git.reviewboard.kde.org/r/108184/diff/
> 
> 
> Testing
> -------
> 
> Yes, compiled and tested
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130105/565fdce7/attachment.html>