<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108184/">http://git.reviewboard.kde.org/r/108184/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can't give a "Ship it", since I don't know what they prefer. The dialog.exec issues should get resolved though.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108184/diff/1/?file=104822#file104822line45" style="color: black; font-weight: bold; text-decoration: underline;">kstars/printing/pwizfovsh.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PWizFovShUI::setBeginObject(SkyObject *obj)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">FindDialog</span> <span class="n">findDlg</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPointer</span><span class="o"><</span><span class="n">FindDialog</span><span class="o">></span> <span class="n">findDlg</span><span class="p">(</span><span class="k">new</span> <span class="n">FindDialog</span><span class="p">(</span><span class="k">this</span><span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see below</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108184/diff/1/?file=104822#file104822line66" style="color: black; font-weight: bold; text-decoration: underline;">kstars/printing/pwizfovsh.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PWizFovShUI::setBeginObject(SkyObject *obj)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">DetailDialo<span class="hl">g</span></span><span class="hl"> </span><span class="n"><span class="hl">detailDl</span>g</span><span class="p">(</span><span class="n">m_ParentWizard</span><span class="o">-></span><span class="n">getShBeginObject</span><span class="p">(),</span> <span class="n">KStars</span><span class="o">::</span><span class="n">Instance</span><span class="p">()</span><span class="o">-></span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">ut</span><span class="p">(),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="n"><span class="hl">QPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n"><span class="hl">DetailDialog</span></span><span class="o"><span class="hl">></span></span><span class="hl"> </span><span class="n"><span class="hl">detailDlg</span></span><span class="p"><span class="hl">(</span></span><span class="k"><span class="hl">new</span></span> <span class="n">DetailDialog</span><span class="p">(</span><span class="n">m_ParentWizard</span><span class="o">-></span><span class="n">getShBeginObject</span><span class="p">(),</span> <span class="n">KStars</span><span class="o">::</span><span class="n">Instance</span><span class="p">()</span><span class="o">-></span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">ut</span><span class="p">(),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that looks a bit awkward to me in terms of coding style. I guess that should rather be
QPointer<DetailDialog> detailDlg = new DetailDialog(m_ParentWizard->getShBeginObject(), KStars::Instance()->data()->ut(),
KStars::Instance()->data()->geo(), this));
But I'm not a KStars guy, so ...
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108184/diff/1/?file=104823#file104823line58" style="color: black; font-weight: bold; text-decoration: underline;">kstars/printing/pwizobjectselection.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PWizObjectSelectionUI::setSkyObject(SkyObject *obj)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">FindDialog</span> <span class="n">findDlg</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPointer</span><span class="o"><</span><span class="n">FindDialog</span><span class="o">></span> <span class="n">findDlg</span><span class="p">(</span><span class="k">new</span> <span class="n">FindDialog</span><span class="p">(</span><span class="k">this</span><span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108184/diff/1/?file=104823#file104823line80" style="color: black; font-weight: bold; text-decoration: underline;">kstars/printing/pwizobjectselection.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PWizObjectSelectionUI::setSkyObject(SkyObject *obj)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">DetailDialo<span class="hl">g</span></span><span class="hl"> </span><span class="n"><span class="hl">detailDl</span>g</span><span class="p">(</span><span class="n">m_ParentWizard</span><span class="o">-></span><span class="n">getSkyObject</span><span class="p">(),</span> <span class="n">KStars</span><span class="o">::</span><span class="n">Instance</span><span class="p">()</span><span class="o">-></span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">ut</span><span class="p">(),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="n"><span class="hl">QPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n"><span class="hl">DetailDialog</span></span><span class="o"><span class="hl">></span></span><span class="hl"> </span><span class="n"><span class="hl">detailDlg</span></span><span class="p"><span class="hl">(</span></span><span class="k"><span class="hl">new</span></span> <span class="n">DetailDialog</span><span class="p">(</span><span class="n">m_ParentWizard</span><span class="o">-></span><span class="n">getSkyObject</span><span class="p">(),</span> <span class="n">KStars</span><span class="o">::</span><span class="n">Instance</span><span class="p">()</span><span class="o">-></span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">ut</span><span class="p">(),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108184/diff/1/?file=104825#file104825line172" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/conjunctions.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ConjunctionsTool::slotFindObject() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">172</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">ld</span><span class="p"><span class="hl">.</span></span><span class="n">exec</span><span class="p">()</span> <span class="o">==</span> <span class="n">QDialog</span><span class="o">::</span><span class="n">Accepted</span> <span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">172</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">ld</span><span class="o"><span class="hl">-></span></span><span class="n">exec</span><span class="p">()</span> <span class="o">==</span> <span class="n">QDialog</span><span class="o">::</span><span class="n">Accepted</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108184/diff/1/?file=104826#file104826line93" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/modcalcvlsr.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void modCalcVlsr::slotFindObject() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">LocationDialog</span> <span class="n">ld</span><span class="p">(</span> <span class="k">this</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPointer</span><span class="o"><</span><span class="n">LocationDialog</span><span class="o">></span> <span class="n">ld</span><span class="p">(</span><span class="k">new</span> <span class="n">LocationDialog</span><span class="p">(</span> <span class="k">this</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On January 4th, 2013, 11:13 p.m., Mayank Madan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mayank Madan.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 11:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://www.google-melange.com/gci/task/view/google/gci2012/8193206</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, compiled and tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/ekos/guide/gmath.cpp <span style="color: grey">(bf629a2)</span></li>
<li>kstars/ekos/guide/guider.cpp <span style="color: grey">(30c6bcd)</span></li>
<li>kstars/ekos/guide/rcalibration.cpp <span style="color: grey">(3340ae4)</span></li>
<li>kstars/ekos/guide/scroll_graph.cpp <span style="color: grey">(a37e81c)</span></li>
<li>kstars/fitsviewer/fitsviewer.cpp <span style="color: grey">(d5c3fcb)</span></li>
<li>kstars/printing/pwizfovsh.cpp <span style="color: grey">(b5a4101)</span></li>
<li>kstars/printing/pwizobjectselection.cpp <span style="color: grey">(50b9f5a)</span></li>
<li>kstars/skyobjects/satellite.cpp <span style="color: grey">(0ca44f7)</span></li>
<li>kstars/tools/conjunctions.cpp <span style="color: grey">(6b8c081)</span></li>
<li>kstars/tools/modcalcvlsr.cpp <span style="color: grey">(2a9b355)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108184/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>