Review Request: Krazy fixes: mark single argument constructors as explicit #3

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108075/#review24396
-----------------------------------------------------------



src/lib/TileCoordsPyramid.h
<http://git.reviewboard.kde.org/r/108075/#comment18696>

    I think that one is ok without, this is a copy constructor



src/lib/layers/VectorTileLayer.cpp
<http://git.reviewboard.kde.org/r/108075/#comment18697>

    while correct for the const & problem, this is also running into another Krazy check (use of keys() to iterate over an associative container.
    Please revert this change, this needs to be solved differently



src/lib/layers/VectorTileLayer.cpp
<http://git.reviewboard.kde.org/r/108075/#comment18698>

    same here



src/lib/layers/VectorTileLayer.cpp
<http://git.reviewboard.kde.org/r/108075/#comment18699>

    same here



tests/ProjectionTest.cpp
<http://git.reviewboard.kde.org/r/108075/#comment18700>

    Also revert please.
    poly is accessed in a non-const way (call to pop_front) so the type used here is appropriate



tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108075/#comment18701>

    The type of gdmlDirname is QString (see line above).
    I think we remove the previous line and move the declaration into the loop
    foreach ( const QString &dgmlDirname, ...



tests/TestGeoSceneWriter.cpp
<http://git.reviewboard.kde.org/r/108075/#comment18702>

    see above


- Kevin Krammer


On Jan. 1, 2013, 10:56 p.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108075/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 10:56 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Add explicit keyword to constructors which could potentially lead to implicit type conversions.
> Also included constant values on variables declared within for-each loop.
> 
> 
> Diffs
> -----
> 
>   src/lib/AbstractWorkerThread.h c0b9ee4 
>   src/lib/BookmarkManager_p.h 4fc3b95 
>   src/lib/ElevationModel.h 69f7e6a 
>   src/lib/MapThemeSortFilterProxyModel.h 95902fe 
>   src/lib/MarbleLineEdit.h 08dc049 
>   src/lib/MarblePluginSettingsWidget.h 926bdef 
>   src/lib/Projections/AbstractProjection_p.h 726c1e4 
>   src/lib/Projections/CylindricalProjection_p.h 4eafd01 
>   src/lib/Projections/SphericalProjection_p.h 60d7396 
>   src/lib/RenderPlugin.h 1ae5385 
>   src/lib/Tile.h 84a3991 
>   src/lib/TileCoordsPyramid.h b669e6c 
>   src/lib/TileScalingTextureMapper.h cf42d45 
>   src/lib/VectorComposer.h 15bd88f 
>   src/lib/VisiblePlacemark.h 3ca463f 
>   src/lib/blendings/BlendingFactory.h a931a7b 
>   src/lib/graphicsview/MarbleGraphicsItem.cpp 7c45ba2 
>   src/lib/kineticmodel.h f505e2e 
>   src/lib/layers/VectorMapLayer.h 91a3f35 
>   src/lib/layers/VectorTileLayer.cpp b43ea9b 
>   tests/ProjectionTest.cpp ce6e5d1 
>   tests/TestGeoDataWriter.cpp 5d509d7 
>   tests/TestGeoSceneWriter.cpp bc2b29f 
>   tools/osm-addresses/OsmRegionTree.h a53b67b 
>   tools/svg2pnt/svgxmlhandler.h 7f899ad 
> 
> Diff: http://git.reviewboard.kde.org/r/108075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130101/c470133b/attachment-0001.html>