<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108075/">http://git.reviewboard.kde.org/r/108075/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108075/diff/1/?file=103725#file103725line27" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/TileCoordsPyramid.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Marble</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">TileCoordsPyramid</span><span class="p">(</span> <span class="n">TileCoordsPyramid</span> <span class="k">const</span> <span class="o">&</span> <span class="n">other</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="hl"> </span><span class="n"><span class="hl">explicit</span></span> <span class="n">TileCoordsPyramid</span><span class="p">(</span> <span class="n">TileCoordsPyramid</span> <span class="k">const</span> <span class="o">&</span> <span class="n">other</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that one is ok without, this is a copy constructor</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108075/diff/1/?file=103733#file103733line170" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/layers/VectorTileLayer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">VectorTileLayer::VectorTileLayer(HttpDownloadManager *downloadManager,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">170</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span> <span class="n">GeoDataLatLonAltBox</span> <span class="n">box</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_documents</span><span class="p">.</span><span class="n">keys</span><span class="p">()</span> <span class="p">){</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">170</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">GeoDataLatLonAltBox</span> <span class="o"><span class="hl">&</span></span><span class="n">box</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_documents</span><span class="p">.</span><span class="n">keys</span><span class="p">()</span> <span class="p">){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">while correct for the const & problem, this is also running into another Krazy check (use of keys() to iterate over an associative container.
Please revert this change, this needs to be solved differently</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108075/diff/1/?file=103733#file103733line257" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/layers/VectorTileLayer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool VectorTileLayer::render( GeoPainter *painter, ViewportParams *viewport,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">257</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span> <span class="n">GeoDataLatLonAltBox</span> <span class="n">box</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_documents</span><span class="p">.</span><span class="n">keys</span><span class="p">()</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">257</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">GeoDataLatLonAltBox</span> <span class="o"><span class="hl">&</span></span><span class="n">box</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_documents</span><span class="p">.</span><span class="n">keys</span><span class="p">()</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108075/diff/1/?file=103733#file103733line331" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/layers/VectorTileLayer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void VectorTileLayer::setVolatileCacheLimit( quint64 kilobytes )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">331</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span> <span class="n">GeoDataLatLonAltBox</span> <span class="n">box</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_documents</span><span class="p">.</span><span class="n">keys</span><span class="p">()</span> <span class="p">){</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">331</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">GeoDataLatLonAltBox</span> <span class="o"><span class="hl">&</span></span><span class="n">box</span> <span class="p">,</span> <span class="n">d</span><span class="o">-></span><span class="n">m_documents</span><span class="p">.</span><span class="n">keys</span><span class="p">()</span> <span class="p">){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108075/diff/1/?file=103734#file103734line160" style="color: black; font-weight: bold; text-decoration: underline;">tests/ProjectionTest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ProjectionTest::drawLineString()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QPolygonF</span><span class="o">*</span> <span class="n">poly</span><span class="p">,</span> <span class="n">polys</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span> <span class="p">(</span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">QPolygonF</span><span class="o">*</span> <span class="o"><span class="hl">&</span></span><span class="n">poly</span><span class="p">,</span> <span class="n">polys</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also revert please.
poly is accessed in a non-const way (call to pop_front) so the type used here is appropriate</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108075/diff/1/?file=103736#file103736line68" style="color: black; font-weight: bold; text-decoration: underline;">tests/TestGeoSceneWriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TestGeoSceneWriter::initTestCase()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span> <span class="n">dgmlDirname</span><span class="p">,</span> <span class="n">dgmlPath</span><span class="p">.</span><span class="n">entryList</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n"><span class="hl">QList</span></span><span class="o"><span class="hl"><</span></span><span class="kt"><span class="hl">int</span></span><span class="o"><span class="hl">></span></span> <span class="n">dgmlDirname</span><span class="p">,</span> <span class="n">dgmlPath</span><span class="p">.</span><span class="n">entryList</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The type of gdmlDirname is QString (see line above).
I think we remove the previous line and move the declaration into the loop
foreach ( const QString &dgmlDirname, ...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108075/diff/1/?file=103736#file103736line80" style="color: black; font-weight: bold; text-decoration: underline;">tests/TestGeoSceneWriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TestGeoSceneWriter::initTestCase()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span> <span class="n">filename</span><span class="p">,</span> <span class="n">dataDir</span><span class="p">.</span><span class="n">entryList</span><span class="p">(</span><span class="n">dgmlFilters</span><span class="p">,</span> <span class="n">QDir</span><span class="o">::</span><span class="n">Files</span><span class="p">)</span> <span class="p">){</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n"><span class="hl">QList</span></span><span class="o"><span class="hl"><</span></span><span class="kt"><span class="hl">int</span></span><span class="o"><span class="hl">></span></span> <span class="n">filename</span><span class="p">,</span> <span class="n">dataDir</span><span class="p">.</span><span class="n">entryList</span><span class="p">(</span><span class="n">dgmlFilters</span><span class="p">,</span> <span class="n">QDir</span><span class="o">::</span><span class="n">Files</span><span class="p">)</span> <span class="p">){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On January 1st, 2013, 10:56 p.m., Kyle Morris wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Kyle Morris.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 10:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add explicit keyword to constructors which could potentially lead to implicit type conversions.
Also included constant values on variables declared within for-each loop.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/AbstractWorkerThread.h <span style="color: grey">(c0b9ee4)</span></li>
<li>src/lib/BookmarkManager_p.h <span style="color: grey">(4fc3b95)</span></li>
<li>src/lib/ElevationModel.h <span style="color: grey">(69f7e6a)</span></li>
<li>src/lib/MapThemeSortFilterProxyModel.h <span style="color: grey">(95902fe)</span></li>
<li>src/lib/MarbleLineEdit.h <span style="color: grey">(08dc049)</span></li>
<li>src/lib/MarblePluginSettingsWidget.h <span style="color: grey">(926bdef)</span></li>
<li>src/lib/Projections/AbstractProjection_p.h <span style="color: grey">(726c1e4)</span></li>
<li>src/lib/Projections/CylindricalProjection_p.h <span style="color: grey">(4eafd01)</span></li>
<li>src/lib/Projections/SphericalProjection_p.h <span style="color: grey">(60d7396)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(1ae5385)</span></li>
<li>src/lib/Tile.h <span style="color: grey">(84a3991)</span></li>
<li>src/lib/TileCoordsPyramid.h <span style="color: grey">(b669e6c)</span></li>
<li>src/lib/TileScalingTextureMapper.h <span style="color: grey">(cf42d45)</span></li>
<li>src/lib/VectorComposer.h <span style="color: grey">(15bd88f)</span></li>
<li>src/lib/VisiblePlacemark.h <span style="color: grey">(3ca463f)</span></li>
<li>src/lib/blendings/BlendingFactory.h <span style="color: grey">(a931a7b)</span></li>
<li>src/lib/graphicsview/MarbleGraphicsItem.cpp <span style="color: grey">(7c45ba2)</span></li>
<li>src/lib/kineticmodel.h <span style="color: grey">(f505e2e)</span></li>
<li>src/lib/layers/VectorMapLayer.h <span style="color: grey">(91a3f35)</span></li>
<li>src/lib/layers/VectorTileLayer.cpp <span style="color: grey">(b43ea9b)</span></li>
<li>tests/ProjectionTest.cpp <span style="color: grey">(ce6e5d1)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(5d509d7)</span></li>
<li>tests/TestGeoSceneWriter.cpp <span style="color: grey">(bc2b29f)</span></li>
<li>tools/osm-addresses/OsmRegionTree.h <span style="color: grey">(a53b67b)</span></li>
<li>tools/svg2pnt/svgxmlhandler.h <span style="color: grey">(7f899ad)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108075/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>