Review Request: Krazy fixes: mark single argument constructors as explicit #3
Kyle Morris
codeinkyle at gmail.com
Tue Jan 1 22:56:51 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108075/
-----------------------------------------------------------
Review request for KDE Edu.
Description
-------
Add explicit keyword to constructors which could potentially lead to implicit type conversions.
Also included constant values on variables declared within for-each loop.
Diffs
-----
src/lib/AbstractWorkerThread.h c0b9ee4
src/lib/BookmarkManager_p.h 4fc3b95
src/lib/ElevationModel.h 69f7e6a
src/lib/MapThemeSortFilterProxyModel.h 95902fe
src/lib/MarbleLineEdit.h 08dc049
src/lib/MarblePluginSettingsWidget.h 926bdef
src/lib/Projections/AbstractProjection_p.h 726c1e4
src/lib/Projections/CylindricalProjection_p.h 4eafd01
src/lib/Projections/SphericalProjection_p.h 60d7396
src/lib/RenderPlugin.h 1ae5385
src/lib/Tile.h 84a3991
src/lib/TileCoordsPyramid.h b669e6c
src/lib/TileScalingTextureMapper.h cf42d45
src/lib/VectorComposer.h 15bd88f
src/lib/VisiblePlacemark.h 3ca463f
src/lib/blendings/BlendingFactory.h a931a7b
src/lib/graphicsview/MarbleGraphicsItem.cpp 7c45ba2
src/lib/kineticmodel.h f505e2e
src/lib/layers/VectorMapLayer.h 91a3f35
src/lib/layers/VectorTileLayer.cpp b43ea9b
tests/ProjectionTest.cpp ce6e5d1
tests/TestGeoDataWriter.cpp 5d509d7
tests/TestGeoSceneWriter.cpp bc2b29f
tools/osm-addresses/OsmRegionTree.h a53b67b
tools/svg2pnt/svgxmlhandler.h 7f899ad
Diff: http://git.reviewboard.kde.org/r/108075/diff/
Testing
-------
Thanks,
Kyle Morris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130101/07134776/attachment.html>
More information about the kde-edu
mailing list