Review Request 108917: Let GenericAffinityTransform and GenericProjectivityTransform use Repeated Points

David Narvaez david.narvaez at
Tue Feb 12 17:00:30 UTC 2013

On Tue, Feb 12, 2013 at 4:06 AM, Maurizio Paolini
<paolini at> wrote:
> I am not in a position to test the patch right now.  But just let me be
> sure I
> understood:  it is just that the constructor did not allow for a duplicate
> object
> among its source arguments, right?   It is my fault... however it would be
> important to test for extreme cases, like all points collapsing into one
> or very few.
> In such cases the transformation could become undefined and we should
> assure that kig
> does not crash (of course it was possible to trick kig into using the same
> coordinates
> for more than one point even before the patch...)
> Anyway, thank you for the patch.

He, I spent like 1 minute thinking what could go wrong, and totally
forgot about degenerated cases :P I'm getting rusty in geometry. I
will work on that suggestion. Could you put this comment up in the
ReviewBoard to keep track of the issue raised? You just need your
Identity account.

David E. Narváez

More information about the kde-edu mailing list