Review Request 108917: Let GenericAffinityTransform and GenericProjectivityTransform use Repeated Points

[Maurizio Paolini]

I am not in a position to test the patch right now.  But just let me be sure I
understood:  it is just that the constructor did not allow for a duplicate object
among its source arguments, right?   It is my fault... however it would be 
important to test for extreme cases, like all points collapsing into one or very few.
In such cases the transformation could become undefined and we should assure that kig
does not crash (of course it was possible to trick kig into using the same coordinates
for more than one point even before the patch...)

Anyway, thank you for the patch.

Maurizio

On Tue, Feb 12, 2013 at 07:55:55AM -0000, David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108917/
> -----------------------------------------------------------
> 
> Review request for KDE Edu and Christoph Feck.
> 
> 
> Description
> -------
> 
> This change is pretty trivial, but I'd like some BIC experts to check if I can commit this to 4.10. This is a year-old bug that was quite trivial to solve and I just realized that, so I wouldn't want users to wait for another major release for a fix.
> 
> 
> Diffs
> -----
> 
>   misc/object_constructor.h fbd019c 
>   misc/special_constructors.h d60d3d7 
>   misc/special_constructors.cc 94f7d50 
> 
> Diff: http://git.reviewboard.kde.org/r/108917/diff/
> 
> 
> Testing
> -------
> 
> 1. Create 4 points
> 2. Create a line
> 3. Create a generic affinity transform that uses 3 of the 4 points as source vertex and 2 of the 3 source vertex plus the 4th point as the 3 destination vertex
> 
> Before this patch, you would end up having 6 points.
> 
> 
> Thanks,
> 
> David Narváez
> 

> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu