Review Request: Adds support for SLC applet, making cantor Activity-Enabled.

[Tomaz Canabrava]

Hm... No problem, I can fix them.  ( and yeh, you shouldn't notice a thing
unless you poke your kactivities - database ^^ ), but may I ask why does
cantor doesn't follow the kdelibs coding std?
usually I code in the kdelibs-standard because I tougth it was used in the
whole kde.

Tomaz

2012/11/1 Alexander Rieder <alexanderrieder at gmail.com>

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107104/
>
> the patch seems good and it compiles and runs fine here(i don't really know how to test the functionality though, but I trust you it works), but it has some coding-style violations. Once these are fixed, feel free to commit.
>
>
>    src/cantor.h<http://git.reviewboard.kde.org/r/107104/diff/1/?file=92728#file92728line101> (Diff
> revision 1)
>
> private:
>
>    101
>
>     KActivities::ResourceInstance *m_activitiesResourceInstance;
>
>   small coding style note: in cantor we usually align the * with the type instead of the variable name
>
>
>    src/cantor.cpp<http://git.reviewboard.kde.org/r/107104/diff/1/?file=92729#file92729line63> (Diff
> revision 1)
>
>    63
>
>     ,m_activitiesResourceInstance(NULL)
>
>   i think the comma should go into the upper line
>
>
>    src/cantor.cpp<http://git.reviewboard.kde.org/r/107104/diff/1/?file=92729#file92729line105> (Diff
> revision 1)
>
> CantorShell::CantorShell()
>
>    105
>
>     if(!m_activitiesResourceInstance){
>
>   as you see in the lines above the cantor coding style has the opening { in its own line.
>
>
>    src/cantor.cpp<http://git.reviewboard.kde.org/r/107104/diff/1/?file=92729#file92729line108> (Diff
> revision 1)
>
> CantorShell::CantorShell()
>
>    108
>
>     }else{
>
>   same here { goes to its own line
>
>
> - Alexander
>
> On October 29th, 2012, 11:24 a.m., Tomaz Canabrava wrote:
>   Review request for KDE Edu.
> By Tomaz Canabrava.
>
> *Updated Oct. 29, 2012, 11:24 a.m.*
> Description
>
> This small patch adds support for Share like Connect and the Activity infrastructure done by Ivan.
>
>   Testing
>
> compiled, not crashing.
>
>   Diffs
>
>    - CMakeLists.txt (7d9d39e)
>    - src/CMakeLists.txt (c92dd99)
>    - src/cantor.h (b401a9c)
>    - src/cantor.cpp (3278b59)
>
> View Diff <http://git.reviewboard.kde.org/r/107104/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121101/a64f5568/attachment-0001.html>