Review Request: Adds support for SLC applet, making cantor Activity-Enabled.

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107104/#review21318
-----------------------------------------------------------


the patch seems good and it compiles and runs fine here(i don't really know how to test the functionality though, but I trust you it works), but it has some coding-style violations. Once these are fixed, feel free to commit.


src/cantor.h
<http://git.reviewboard.kde.org/r/107104/#comment16598>

    small coding style note: in cantor we usually align the * with the type instead of the variable name



src/cantor.cpp
<http://git.reviewboard.kde.org/r/107104/#comment16599>

    i think the comma should go into the upper line



src/cantor.cpp
<http://git.reviewboard.kde.org/r/107104/#comment16600>

    as you see in the lines above the cantor coding style has the opening { in its own line.



src/cantor.cpp
<http://git.reviewboard.kde.org/r/107104/#comment16604>

    same here { goes to its own line


- Alexander Rieder


On Oct. 29, 2012, 11:24 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107104/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 11:24 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This small patch adds support for Share like Connect and the Activity infrastructure done by Ivan.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7d9d39e 
>   src/CMakeLists.txt c92dd99 
>   src/cantor.h b401a9c 
>   src/cantor.cpp 3278b59 
> 
> Diff: http://git.reviewboard.kde.org/r/107104/diff/
> 
> 
> Testing
> -------
> 
> compiled, not crashing.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121101/1dcb2a6a/attachment.html>