<div class="gmail_quote">Hm... No problem, I can fix them. ( and yeh, you shouldn't notice a thing unless you poke your kactivities - database ^^ ), but may I ask why does cantor doesn't follow the kdelibs coding std?<br>
usually I code in the kdelibs-standard because I tougth it was used in the whole kde.<br><br>Tomaz<br><br>2012/11/1 Alexander Rieder <span dir="ltr"><<a href="mailto:alexanderrieder@gmail.com" target="_blank">alexanderrieder@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" cellpadding="8" width="100%" bgcolor="#f9f3c9">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107104/" target="_blank">http://git.reviewboard.kde.org/r/107104/</a>
</td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">the patch seems good and it compiles and runs fine here(i don't really know how to test the functionality though, but I trust you it works), but it has some coding-style violations. Once these are fixed, feel free to commit.</pre>
<br>
<div>
<table width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left" bgcolor="#F0F0F0">
<a href="http://git.reviewboard.kde.org/r/107104/diff/1/?file=92728#file92728line101" style="text-decoration:underline;font-weight:bold" target="_blank">src/cantor.h</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font>101</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>KActivities</span><span>::</span><span>ResourceInstance</span> <span>*</span><span>m_activitiesResourceInstance</span><span>;</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">small coding style note: in cantor we usually align the * with the type instead of the variable name</pre>
</div>
<br>
<div>
<table width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left" bgcolor="#F0F0F0">
<a href="http://git.reviewboard.kde.org/r/107104/diff/1/?file=92729#file92729line63" style="text-decoration:underline;font-weight:bold" target="_blank">src/cantor.cpp</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font>63</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>,</span><span>m_activitiesResourceInstance</span><span>(</span><span>NULL</span><span>)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">i think the comma should go into the upper line</pre>
</div>
<br>
<div>
<table width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left" bgcolor="#F0F0F0">
<a href="http://git.reviewboard.kde.org/r/107104/diff/1/?file=92729#file92729line105" style="text-decoration:underline;font-weight:bold" target="_blank">src/cantor.cpp</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">CantorShell::CantorShell()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font>105</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>if</span><span>(</span><span>!</span><span>m_activitiesResourceInstance</span><span>){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">as you see in the lines above the cantor coding style has the opening { in its own line.</pre>
</div>
<br>
<div>
<table width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left" bgcolor="#F0F0F0">
<a href="http://git.reviewboard.kde.org/r/107104/diff/1/?file=92729#file92729line108" style="text-decoration:underline;font-weight:bold" target="_blank">src/cantor.cpp</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">CantorShell::CantorShell()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" bgcolor="#b1ebb0"><font>108</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>}</span><span>else</span><span>{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">same here { goes to its own line</pre>
</div>
<br>
<p>- Alexander</p><div class="im">
<br>
<p>On October 29th, 2012, 11:24 a.m., Tomaz Canabrava wrote:</p>
</div><table style="background-image:url('');background-repeat:repeat-x;border:1px black solid" cellpadding="8" cellspacing="0" width="100%" bgcolor="#fefadf">
<tbody><tr>
<td><div class="im">
<div>Review request for KDE Edu.</div>
<div>By Tomaz Canabrava.</div>
</div><p style="color:grey"><i>Updated Oct. 29, 2012, 11:24 a.m.</i></p><div class="im">
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" cellpadding="10" cellspacing="0" width="100%" bgcolor="#ffffff">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This small patch adds support for Share like Connect and the Activity infrastructure done by Ivan.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" cellpadding="10" cellspacing="0" width="100%" bgcolor="#ffffff">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">compiled, not crashing.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>CMakeLists.txt <span style="color:grey">(7d9d39e)</span></li>
<li>src/CMakeLists.txt <span style="color:grey">(c92dd99)</span></li>
<li>src/cantor.h <span style="color:grey">(b401a9c)</span></li>
<li>src/cantor.cpp <span style="color:grey">(3278b59)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107104/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br>