KmPlot sliders usage and associated bug

[Anne-Marie Mahfouf]

On 03/04/2012 09:02 AM, Rahul Sharma wrote:
> Hi,
> I looked into the view.cpp updatesliders() function, and I have 
> arrived at the conclusion that the variable needSliderWindow does have 
> a use here. I think that the control if() statement, in which the bool 
> variable needSliderWindow is set to true, it checks whether the Slider 
> checkbox in the left panel (function tab) is checked or not, depending 
> on which it sets the checkable bool of m_menuSliderAction to true.
>
> And I think the intention was that when the Slider checkbox is 
> checked, the slider window should pop-up and when it is unchecked 
> slider window should hide.
So the first thing would be to fix this.
Should closing the Sliders window uncheck the Slider checkbox? What 
should happen when the Sliders window is closed?
Also why is there the possibility to check Slider when there is no 
Slider use? Like in a function witn no parameter.

Anne-Marie

> And as you were saying there is no need to have that as a toggle. That 
> can be done in another way and just setting 
> m_menuSliderAction->setchecked(true) does not fulfill the aim here.
>
> And one more thing I wanted to point out here is about my patch. 
> Actually, when I looked into the code of the ksliderwindow.cpp, I 
> found out that in order to handle the check of the m_menuSliderAction 
> there is a slot called closeevent which emits a windowclosed signal 
> when the window is closed, which is only called when closeevent is 
> called. But the close button of the slider window uses a done() 
> (perhaps inheritted from QDialog as far as I remember) to close the 
> window which does not emit a closeevent and the the m_menuSliderAction 
> becomes faulty, so I just fixed that.
>
> -Regards
>  Rahul Sharma
>  (NUM_1 on irc.freenode.net <http://irc.freenode.net>)
>
> On Fri, Mar 2, 2012 at 11:08 PM, Rahul Sharma 
> <rahulveera2009 at gmail.com <mailto:rahulveera2009 at gmail.com>> wrote:
>
>     Ok, I'll look into this. I would inform you soon as I get some
>     hint on the intention of the slider window and also about patch
>     from comment 3.
>
>
>     On Fri, Mar 2, 2012 at 8:30 PM, Anne-Marie Mahfouf
>     <annemarie.mahfouf at free.fr <mailto:annemarie.mahfouf at free.fr>> wrote:
>
>         On 03/02/2012 01:10 PM, Rahul Sharma wrote:
>
>             Hi Anne-Marie,
>             First of all, thanks for having a look at my review-request.
>             I fully understand what you say, and as you had said
>             earlier I had sent a mail to the mailing list regarding
>             this issue.
>             But I could not get good suggestions on it, and meanwhile
>             I found out why the "close" button didn't behave as
>             expected for toggle, so I sent this patch and Lueck
>             confirmed that the patch worked for him.
>
>
>         OK so I removed slidersWindowClosed(); to solve 1)
>
>         There is some code to investigate to understand those sliders:
>         in view.cpp, line 3929 we have
>         void View::updateSliders()
>         which does things I do not understand.
>         What's the bool needSliderWindow use?
>         Could it be that the Close button on the dialog is like "Hide"
>         and that patch from comment 3 in the bug report is right?
>         If you can explain the above I think we'll know more about the
>         intention of the code.
>
>         Are you up to look into this? I don't think the developer who
>         coded this is still involved in this mailing list so it's up
>         to us to fix this properly.
>
>
>         Anne-Marie
>
>
>
>         _______________________________________________
>         kde-edu mailing list
>         kde-edu at mail.kde.org <mailto:kde-edu at mail.kde.org>
>         https://mail.kde.org/mailman/listinfo/kde-edu
>
>
>
>
> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120304/156ffc54/attachment.html>