<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
On 03/04/2012 09:02 AM, Rahul Sharma wrote:
<blockquote
cite="mid:CAC3EFMj_Obi3cG16HrStamKACxgAocjx7FA5OO5Dv0xn+j76_w@mail.gmail.com"
type="cite">Hi,<br>
I looked into the view.cpp updatesliders() function, and I have
arrived at the conclusion that the variable needSliderWindow does
have a use here. I think that the control if() statement, in which
the bool variable needSliderWindow is set to true, it checks
whether the Slider checkbox in the left panel (function tab) is
checked or not, depending on which it sets the checkable bool of
m_menuSliderAction to true.<br>
<br>
And I think the intention was that when the Slider checkbox is
checked, the slider window should pop-up and when it is unchecked
slider window should hide.<br>
</blockquote>
So the first thing would be to fix this. <br>
Should closing the Sliders window uncheck the Slider checkbox? What
should happen when the Sliders window is closed?<br>
Also why is there the possibility to check Slider when there is no
Slider use? Like in a function witn no parameter.<br>
<br>
Anne-Marie<br>
<br>
<blockquote
cite="mid:CAC3EFMj_Obi3cG16HrStamKACxgAocjx7FA5OO5Dv0xn+j76_w@mail.gmail.com"
type="cite">And as you were saying there is no need to have that
as a toggle. That can be done in another way and just setting
m_menuSliderAction->setchecked(true) does not fulfill the aim
here.<br>
<br>
And one more thing I wanted to point out here is about my patch.
Actually, when I looked into the code of the ksliderwindow.cpp, I
found out that in order to handle the check of the
m_menuSliderAction there is a slot called closeevent which emits a
windowclosed signal when the window is closed, which is only
called when closeevent is called. But the close button of the
slider window uses a done() (perhaps inheritted from QDialog as
far as I remember) to close the window which does not emit a
closeevent and the the m_menuSliderAction becomes faulty, so I
just fixed that.<br>
<br>
-Regards<br>
Rahul Sharma<br>
(NUM_1 on <a moz-do-not-send="true"
href="http://irc.freenode.net">irc.freenode.net</a>)<br>
<br>
<div class="gmail_quote">On Fri, Mar 2, 2012 at 11:08 PM, Rahul
Sharma <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:rahulveera2009@gmail.com">rahulveera2009@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">Ok, I'll look into this. I would inform
you soon as I get some hint on the intention of the slider
window and also about patch from comment 3.
<div class="HOEnZb">
<div class="h5"><br>
<br>
<div class="gmail_quote">On Fri, Mar 2, 2012 at 8:30 PM,
Anne-Marie Mahfouf <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:annemarie.mahfouf@free.fr"
target="_blank">annemarie.mahfouf@free.fr</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div>On 03/02/2012 01:10 PM, Rahul Sharma wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt
0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;">
Hi Anne-Marie,<br>
First of all, thanks for having a look at my
review-request.<br>
I fully understand what you say, and as you had
said earlier I had sent a mail to the mailing list
regarding this issue.<br>
But I could not get good suggestions on it, and
meanwhile I found out why the "close" button
didn't behave as expected for toggle, so I sent
this patch and Lueck confirmed that the patch
worked for him.<br>
</blockquote>
<br>
</div>
OK so I removed slidersWindowClosed(); to solve 1)<br>
<br>
There is some code to investigate to understand those
sliders: in view.cpp, line 3929 we have<br>
void View::updateSliders()<br>
which does things I do not understand.<br>
What's the bool needSliderWindow use?<br>
Could it be that the Close button on the dialog is
like "Hide" and that patch from comment 3 in the bug
report is right?<br>
If you can explain the above I think we'll know more
about the intention of the code.<br>
<br>
Are you up to look into this? I don't think the
developer who coded this is still involved in this
mailing list so it's up to us to fix this properly.<span><font
color="#888888"><br>
<br>
<br>
Anne-Marie</font></span>
<div>
<div><br>
<br>
<br>
_______________________________________________<br>
kde-edu mailing list<br>
<a moz-do-not-send="true"
href="mailto:kde-edu@mail.kde.org"
target="_blank">kde-edu@mail.kde.org</a><br>
<a moz-do-not-send="true"
href="https://mail.kde.org/mailman/listinfo/kde-edu"
target="_blank">https://mail.kde.org/mailman/listinfo/kde-edu</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
kde-edu mailing list
<a class="moz-txt-link-abbreviated" href="mailto:kde-edu@mail.kde.org">kde-edu@mail.kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/kde-edu">https://mail.kde.org/mailman/listinfo/kde-edu</a>
</pre>
</blockquote>
<br>
</body>
</html>