KmPlot sliders usage and associated bug

[Rahul Sharma]

Ok, I'll look into this. I would inform you soon as I get some hint on the
intention of the slider window and also about patch from comment 3.

On Fri, Mar 2, 2012 at 8:30 PM, Anne-Marie Mahfouf <
annemarie.mahfouf at free.fr> wrote:

> On 03/02/2012 01:10 PM, Rahul Sharma wrote:
>
>> Hi Anne-Marie,
>> First of all, thanks for having a look at my review-request.
>> I fully understand what you say, and as you had said earlier I had sent a
>> mail to the mailing list regarding this issue.
>> But I could not get good suggestions on it, and meanwhile I found out why
>> the "close" button didn't behave as expected for toggle, so I sent this
>> patch and Lueck confirmed that the patch worked for him.
>>
>
> OK so I removed slidersWindowClosed(); to solve 1)
>
> There is some code to investigate to understand those sliders: in
> view.cpp, line 3929 we have
> void View::updateSliders()
> which does things I do not understand.
> What's the bool needSliderWindow use?
> Could it be that the Close button on the dialog is like "Hide" and that
> patch from comment 3 in the bug report is right?
> If you can explain the above I think we'll know more about the intention
> of the code.
>
> Are you up to look into this? I don't think the developer who coded this
> is still involved in this mailing list so it's up to us to fix this
> properly.
>
>
> Anne-Marie
>
>
>
> ______________________________**_________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/**listinfo/kde-edu<https://mail.kde.org/mailman/listinfo/kde-edu>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120302/6c4b2306/attachment.html>