KmPlot sliders usage and associated bug

[Rahul Sharma]

Hi Anne-Marie,
First of all, thanks for having a look at my review-request.
I fully understand what you say, and as you had said earlier I had sent a
mail to the mailing list regarding this issue.
But I could not get good suggestions on it, and meanwhile I found out why
the "close" button didn't behave as expected for toggle, so I sent this
patch and Lueck confirmed that the patch worked for him.

Anyways, I am still looking over for further improvements/suggestions so
that I myself can implement those.

Thanks,
Rahul Sharma
(NUM_1 on irc.freenode.net)

On Fri, Mar 2, 2012 at 3:31 PM, Anne-Marie Mahfouf <
annemarie.mahfouf at free.fr> wrote:

> Hi,
>
> There is a bug http://bugs.kde.org/show_bug.**cgi?id=152182<http://bugs.kde.org/show_bug.cgi?id=152182>about the Sliders dialog. A patch is proposed but I am not satisfied with
> it. Technically the patch works and the student did well. But in my
> opinion, the problem must be tackled in another way and for that we need
> KmPlot developers and power users to help.
>
> I'd like some highlights on the following points about KmPlot Sliders
> dialog and design decisions, especially point 3):
>
> 1) In the View class we already have 2 methods [void sliderWindowClosed();
> and void slidersWindowClosed();] for setting the m_menuSliderAction to
> false. So instead of adding a new method this should be fixed here. And see
> why there are 2 such methods.
> 2) Is there a need for a toggle action as the dialog is either shown or
> not (doesn't it behave exactly as the Coordinate System dialog?) I would
> make it a simple action "Show Sliders..." to open the dialog.
> 3) As I said in the mail when we discussed this bug, the sliders behavior
> should be clarified. According to http://userbase.kde.org/**
> KmPlot/Using_Sliders <http://userbase.kde.org/KmPlot/Using_Sliders> the
> sliders modify a parameter value. If there is no parameter, the dialog does
> nothing, as does nothing checking "Slider 1" in the tab. So should this be
> available at all in those cases?
>
> Best regards,
>
> Anne-Marie
>
> PS: https://git.reviewboard.kde.**org/r/104138/<https://git.reviewboard.kde.org/r/104138/>
> ______________________________**_________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/**listinfo/kde-edu<https://mail.kde.org/mailman/listinfo/kde-edu>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120302/aa7d7dcb/attachment.html>